reset server.abended state after successful isMaster call #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
candidate fix for: https://github.com/go-mgo/mgo/issues/254 |
|
@wgallagher Have you had any experience with using your suggested fix in production? See my updates on #254 . Thank you. |
|
We have been running this in production for months. It resolved the issue. |
|
Thanks. We are going to try it too. |
|
I intended to upstream but coming up with a testcase but the issue is hard to repro. |
|
Any updates on this? A single timeout causes excessive CPU usage due to isMaster calls. |
jackyvictory
added a commit
to jackyvictory/mgo
that referenced
this pull request
Jul 19, 2017
parvathi-nair
pushed a commit
to CiscoM31/mgo
that referenced
this pull request
Sep 14, 2018
Revert "Test against Mongo minor releases updates as of Aug 2018"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/go-mgo/mgo/issues/254